-
-
Notifications
You must be signed in to change notification settings - Fork 231
chore: add change_tunables
#3886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add change_tunables
#3886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor change, looks good otherwise (assuming tests pass)
docs/src/API/model_building.md
Outdated
@@ -226,6 +226,7 @@ change_independent_variable | |||
add_accumulations | |||
noise_to_brownians | |||
convert_system_indepvar | |||
ModelingToolkit.subset_tunables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To stay on theme with #3884, let's mark this function using @public
near the bottom of src/ModelingToolkit.jl
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 8c8dbf8
CI seems unreliable; I haven't modified existing code in this PR |
Yeah it is. I mentioned it several times on slack, hopefully we get a fix soon. I'm manually rerunning it until we get a result in the meantime. |
…ngToolkit.jl into dg/change_tunables
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
closes #3772
Add any other context about the problem here.