Skip to content

chore: add change_tunables #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 12, 2025

Conversation

DhairyaLGandhi
Copy link
Member

@DhairyaLGandhi DhairyaLGandhi commented Aug 11, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

closes #3772

Add any other context about the problem here.

Copy link
Member

@AayushSabharwal AayushSabharwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change, looks good otherwise (assuming tests pass)

@@ -226,6 +226,7 @@ change_independent_variable
add_accumulations
noise_to_brownians
convert_system_indepvar
ModelingToolkit.subset_tunables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To stay on theme with #3884, let's mark this function using @public near the bottom of src/ModelingToolkit.jl?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 8c8dbf8

@DhairyaLGandhi
Copy link
Member Author

CI seems unreliable; I haven't modified existing code in this PR

@AayushSabharwal
Copy link
Member

Yeah it is. I mentioned it several times on slack, hopefully we get a fix soon. I'm manually rerunning it until we get a result in the meantime.

@AayushSabharwal AayushSabharwal merged commit a62cb14 into SciML:master Aug 12, 2025
87 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow subsetting tunables after system creation
2 participants